Messages in this thread | | | Date | Wed, 18 May 2022 19:34:15 +0800 | From | Tzung-Bi Shih <> | Subject | Re: [PATCH] platform/chrome: cros_ec_proto: update cros_ec_check_result() comment |
| |
On Tue, May 17, 2022 at 04:28:17PM +0800, Tzung-Bi Shih wrote: > At first glance, cros_ec_check_result() is quite like cros_ec_map_error(). > They check for `ec_msg->result` and return corresponding errors. However, > as calling from `pkt_xfer` and `cmd_xfer`, cros_ec_check_result() should > not report furthermore errors. -EAGAIN is the only exception. > > See [1][2][3] for some known userland programs' code. The return code > from ioctl only denotes the EC communication status. Userland programs > would further analyze the `result` in struct cros_ec_command* for > follow-up actions (e.g. [4]). > > To clarify, update the function comment.
Pardon me if it is confusing. The patch now merged into a series in order to make more sense. Let's ignore the patch and move discussion to [5] if any.
[5]: https://patchwork.kernel.org/project/chrome-platform/patch/20220518091814.2028579-4-tzungbi@kernel.org/
| |