lkml.org 
[lkml]   [2022]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] netfs: Use container_of() for offset casting
Date
From: David Howells 
> Sent: 18 May 2022 09:05
>
> I wonder if it would be worth making this explicit in the inode wrappers of
> the users of netfslib. In afs, for instance, there is:
>
> struct afs_vnode {
> struct {
> /* These must be contiguous */
> struct inode vfs_inode;
> struct netfs_i_context netfs_ctx;
> };
> ...
> };
>
> would it be worth making that:
>
> struct afs_vnode {
> union {
> struct netfs_i_c_pair netfs_inode;
> struct {
> /* These must be contiguous */
> struct inode vfs_inode;
> struct netfs_i_context netfs_ctx;
> };
> };
> ...
> };
>

Can't you just name the structure so it is:

struct afs_vnode {
struct netfs_i_c_pair {
/* These must be contiguous */
struct inode vfs_inode;
struct netfs_i_context netfs_ctx;
};
...
};

David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)

\
 
 \ /
  Last update: 2022-05-18 12:04    [W:0.597 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site