lkml.org 
[lkml]   [2022]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 06/15] mm/swap: remove buggy cache->nr check in refill_swap_slots_cache
On Mon, May 09, 2022 at 09:14:07PM +0800, Miaohe Lin wrote:
> refill_swap_slots_cache is always called when cache->nr is 0. And if
> cache->nr != 0, we should return cache->nr instead of 0. So remove
> such buggy and confusing check.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>

With Andrew's ammendment:

Reviewed-by: Oscar Salvador <osalvador@suse.de>

> ---
> mm/swap_slots.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/swap_slots.c b/mm/swap_slots.c
> index 2f877e6f87d7..2a65a89b5b4d 100644
> --- a/mm/swap_slots.c
> +++ b/mm/swap_slots.c
> @@ -258,7 +258,7 @@ void enable_swap_slots_cache(void)
> /* called with swap slot cache's alloc lock held */
> static int refill_swap_slots_cache(struct swap_slots_cache *cache)
> {
> - if (!use_swap_slot_cache || cache->nr)
> + if (!use_swap_slot_cache)
> return 0;
>
> cache->cur = 0;
> --
> 2.23.0
>
>

--
Oscar Salvador
SUSE Labs

\
 
 \ /
  Last update: 2022-05-18 11:42    [W:0.422 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site