Messages in this thread | | | Date | Wed, 18 May 2022 11:24:21 +0200 | Subject | Re: [PATCH 2/6] dt-bindings: arm: mt8186: Set #clock-cells as required property | From | AngeloGioacchino Del Regno <> |
| |
Il 17/05/22 16:34, Krzysztof Kozlowski ha scritto: > On 17/05/2022 12:15, AngeloGioacchino Del Regno wrote: >> This is a clock-controller binding, so it needs #clock-cells, or >> it would be of no use: add that to the list of required properties. >> >> Fixes: f113a51aa2cf ("dt-bindings: ARM: MediaTek: Add new document bindings of MT8186 clock") >> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> >> --- >> .../devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml | 1 + > > If these are clock controllers and new bindings, why they were added to > "arm" directory? arm is only for top-level stuff, not for devices. > > In the future please put your bindings in respective subsystem matching > the hardware. Fallback is soc directory, not arm. > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >
Hello Krzysztof,
I agree with you about these bindings belonging to the clock directory. Should I add a patch to this series that moves all of the mtxxxx-clock and mtxxxx-sys-clock yaml files to the clock directory?
Regards, Angelo
| |