Messages in this thread | | | Date | Wed, 18 May 2022 10:14:43 +0200 | Subject | Re: [PATCH 7/8] dt-bindings: iommu: mediatek: Require mediatek,infracfg for mt2712/8173 | From | AngeloGioacchino Del Regno <> |
| |
Il 18/05/22 03:41, Rob Herring ha scritto: > On Tue, May 17, 2022 at 03:21:06PM +0200, AngeloGioacchino Del Regno wrote: >> Both MT2712 and MT8173 got a mediatek,infracfg phandle: add that to >> the required properties for these SoCs to deprecate the old way of >> looking for SoC-specific infracfg compatible in the entire devicetree. > > Wait, what? If there's only one possible node that can match, I prefer > the 'old way'. Until we implemented a phandle cache, searching the > entire tree was how phandle lookups worked too, so not any better. > > But if this makes things more consistent, > > Acked-by: Rob Herring <robh@kernel.org>
Hello Rob,
This makes things definitely more consistent, as it's done like that on mtk-pm-domains and other mtk drivers as well.
The main reason why this phandle is useful, here and in other drivers, is that we're seeing a list of compatibles that is growing more and more, so you see stuff like (mockup names warning):
switch (some_model) case MT1000: p = "mediatek,mt1000-infracfg"; break; case MT1001: p = "mediatek,mt1001-infracfg"; break; case MT1002: p = "mediatek,mt1002-infracfg"; break; .....add another 20 SoCs, replicate this switch for 4/5 drivers....
and this is why I want the mtk_iommu driver to also get that phandle like some other drivers are already doing.
By the way, thanks for the ack!
Regards, Angelo
| |