Messages in this thread | | | Date | Wed, 18 May 2022 15:19:04 +0800 | From | Tzung-Bi Shih <> | Subject | Re: [PATCH 1/2] platform/chrome: Use tables for values lists of ChromeOS ACPI sysfs ABI |
| |
On Wed, May 18, 2022 at 01:50:26PM +0700, Bagas Sanjaya wrote: > On 5/18/22 10:37, Tzung-Bi Shih wrote: > > On Wed, May 18, 2022 at 10:17:50AM +0700, Bagas Sanjaya wrote: > >> What: /sys/bus/platform/devices/GGL0001:*/CHSW > >> Date: May 2022 > >> KernelVersion: 5.19 > >> Description: > >> This file shows the switch position for the Chrome OS specific > >> - hardware switches. > >> - * 0 - No changes. > >> - * 2 - Recovery button was pressed when firmware booted. > >> - * 4 - Recovery button was pressed when EC firmware booted. > >> - * 32 - Developer switch was enabled when firmware booted. > >> - * 512 - Firmware write protection was disabled when firmware > >> - booted. > >> + hardware switches when the firmare is booted. > > > > s/firmare/firmware/. > > > > Could you fix it in v2 and also Cc to <chrome-platform@lists.linux.dev>? > > OK, but regarding the schedule, we are on -rc7 (official mainline release > will be imminent). Maybe I can send the v2 immediately, or should I wait > for a day?
I think either way is fine. The patch introduced the sphinx warning is still in chrome-platform's for-next branch[1]. And it should send to mainline when the next merge window opens.
[1]: https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git/commit/?h=for-next&id=0a4cad9c11ad46662ede48d94f08ecb7cd9f6916
| |