Messages in this thread | | | Date | Wed, 18 May 2022 09:04:44 +0200 | From | Greg KH <> | Subject | Re: [PATCH v4 2/8] drivers: base: Add Kconfig/Makefile to build hardware prefetch control core driver |
| |
On Wed, May 18, 2022 at 03:30:26PM +0900, Kohei Tarumizu wrote: > Adds Kconfig/Makefile to build hardware prefetch control core driver, > and also adds a MAINTAINERS entry. > > Signed-off-by: Kohei Tarumizu <tarumizu.kohei@fujitsu.com> > --- > MAINTAINERS | 6 ++++++ > drivers/base/Kconfig | 9 +++++++++ > drivers/base/Makefile | 1 + > 3 files changed, 16 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index d6d879cb0afd..f188403bc2e9 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -8620,6 +8620,12 @@ F: include/linux/hwmon*.h > F: include/trace/events/hwmon*.h > K: (devm_)?hwmon_device_(un)?register(|_with_groups|_with_info) > > +HARDWARE PREFETCH CONTROL DRIVERS > +M: Kohei Tarumizu <tarumizu.kohei@fujitsu.com> > +S: Maintained > +F: drivers/base/pfctl.c > +F: include/linux/pfctl.h > + > HARDWARE RANDOM NUMBER GENERATOR CORE > M: Matt Mackall <mpm@selenic.com> > M: Herbert Xu <herbert@gondor.apana.org.au> > diff --git a/drivers/base/Kconfig b/drivers/base/Kconfig > index 6f04b831a5c0..8f8a69e7f645 100644 > --- a/drivers/base/Kconfig > +++ b/drivers/base/Kconfig > @@ -230,4 +230,13 @@ config GENERIC_ARCH_NUMA > Enable support for generic NUMA implementation. Currently, RISC-V > and ARM64 use it. > > +config HWPF_CONTROL
Shouldn't this have "GENERIC" in the name liks the other generic implementations in this directory?
> + bool "Hardware Prefetch Control driver" > + help > + This driver allows user to control CPU's Hardware Prefetch behavior. > + If the machine supports this behavior, it provides a sysfs interface.
But this is not a driver, it's a core function that a driver uses. On its own, this code does nothing.
thanks,
greg k-h
| |