lkml.org 
[lkml]   [2022]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/5] ACPI: CPPC: Check _OSC for flexible address space
On 18-05-22, 12:34, Pierre Gondois wrote:
>
>
> On 5/18/22 11:42, Viresh Kumar wrote:
> > On 18-05-22, 11:08, Pierre Gondois wrote:
> > > ACPI 6.2 Section 6.2.11.2 'Platform-Wide OSPM Capabilities':
> > > Starting with ACPI Specification 6.2, all _CPC registers can be in
> > > PCC, System Memory, System IO, or Functional Fixed Hardware address
> > > spaces. OSPM support for this more flexible register space scheme is
> > > indicated by the “Flexible Address Space for CPPC Registers” _OSC bit
> > >
> > > Otherwise (cf ACPI 6.1, s8.4.7.1.1.X), _CPC registers must be in:
> > > - PCC or Functional Fixed Hardware address space if defined
> > > - SystemMemory address space (NULL register) if not defined
> > >
> > > Add the corresponding _OSC bit and check it when parsing _CPC objects.
> > >
> > > Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
> > > Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
> > > ---
> > > drivers/acpi/bus.c | 18 ++++++++++++++++++
> > > drivers/acpi/cppc_acpi.c | 9 +++++++++
> > > include/linux/acpi.h | 2 ++
> > > 3 files changed, 29 insertions(+)
> >
> > It would be much useful to get a cover letter for this series with
> > what you have changed since the previous version. It is almost
> > impossible to find that out otherwise.
> >
>
> Yes indeed, sorry for that, the changelog is:
> v2:
> [1/5] ACPI: CPPC: Check _OSC for flexible address space
> - Renamed OSC_SB_CPC_FLEXIBLE_ADR_SP to OSC_SB_CPC_FLEXIBLE_ADR_SPACE
> [3/5] ACPI: CPPC: Assume no transition latency if no PCCT
> and
> [4/5] cpufreq: CPPC: Enable fast_switch
> - Renamed CPC_IN_SIO to CPC_IN_SYSTEM_IO
> - Renamed CPC_IN_SM to CPC_IN_SYSTEM_MEMORY
>
> or do you prefer to have the serie re-submitted ?

No it is fine for now :)

--
viresh

\
 
 \ /
  Last update: 2022-09-17 16:22    [W:0.233 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site