lkml.org 
[lkml]   [2022]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH -next] usb: host: ohci-tmio: Fix unchecked return value for device_wakeup_enable
Date
The return value of device_wakeup_enable() is unchecked, as the result
usb_remove_hcd() is unreachable even if device_wakeup_enable() is failed.

Fixes: 78c73414f4f6 ("USB: ohci: add support for tmio-ohci cell")

Signed-off-by: Li Zhengyu <lizhengyu3@huawei.com>
---
drivers/usb/host/ohci-tmio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/host/ohci-tmio.c b/drivers/usb/host/ohci-tmio.c
index 49539b9f0e94..8148dc90c066 100644
--- a/drivers/usb/host/ohci-tmio.c
+++ b/drivers/usb/host/ohci-tmio.c
@@ -244,7 +244,7 @@ static int ohci_hcd_tmio_drv_probe(struct platform_device *dev)
if (ret)
goto err_add_hcd;

- device_wakeup_enable(hcd->self.controller);
+ ret = device_wakeup_enable(hcd->self.controller);
if (ret == 0)
return ret;

--
2.17.1
\
 
 \ /
  Last update: 2022-05-19 04:06    [W:0.063 / U:0.656 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site