Messages in this thread | | | Date | Wed, 18 May 2022 08:51:23 +0200 | Subject | Re: [PATCH] x86: xen: remove STACK_FRAME_NON_STANDARD from xen_cpuid | From | Juergen Gross <> |
| |
On 17.05.22 18:42, Josh Poimboeuf wrote: > On Tue, May 17, 2022 at 04:24:25PM +0000, Maximilian Heyne wrote: >> Since commit 4d65adfcd119 ("x86: xen: insn: Decode Xen and KVM >> emulate-prefix signature"), objtool is able to correctly parse the >> prefixed instruction in xen_cpuid and emit correct orc unwind >> information. Hence, marking the function as STACKFRAME_NON_STANDARD is >> no longer needed. >> >> This commit is basically a revert of commit 983bb6d254c7 ("x86/xen: Mark >> xen_cpuid() stack frame as non-standard"). >> >> Signed-off-by: Maximilian Heyne <mheyne@amazon.de> >> CC: Josh Poimboeuf <jpoimboe@kernel.org> >> >> cr: https://code.amazon.com/reviews/CR-69645080 > ^^^^^ > > This looks like an internal amazon link and should be removed. > Otherwise, looks good to me.
Can be done while committing.
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen [unhandled content-type:application/pgp-keys][unhandled content-type:application/pgp-signature] | |