Messages in this thread | | | Subject | Re: [PATCH -next] cgroup: Make cgroup_debug static | From | xiujianfeng <> | Date | Wed, 18 May 2022 14:48:36 +0800 |
| |
在 2022/5/18 1:06, Tejun Heo 写道: > On Tue, May 17, 2022 at 07:25:23PM +0800, Xiu Jianfeng wrote: >> Make cgroup_debug static since it's only used in cgroup.c >> >> Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com> > The only thing it does is gating CFTYPE_DEBUG which isn't used anymore. > Can you remove both CFTYPE_DEBUG and cgroup_debug() instead?
It's ok to me, but I found CFTYPE_DEBUG is still used in cpuset subsys,
.name = "cpus.subpartitions", .seq_show = cpuset_common_seq_show, .private = FILE_SUBPARTS_CPULIST, .flags = CFTYPE_DEBUG,
if remove CFTYPE_DEBUG and cgroup_debug, cpus.subpartitions will be showed by default, is this ok?
> > Thanks. >
| |