Messages in this thread | | | Subject | Re: [PATCH V5 0/3] Add unit test module for AMD P-State driver | From | Shuah Khan <> | Date | Wed, 18 May 2022 14:02:38 -0600 |
| |
On 5/17/22 11:19 PM, Huang Rui wrote: > On Wed, May 18, 2022 at 04:03:05AM +0800, Shuah Khan wrote:
>> I reviewed the patches and the test driver amd-pstate-ut doesn't belong under >> selftests. I would recommend the following approach: >> >> - add this test driver under drivers/cpufreq >> >> - KUnit is a better fit for this unit test driver unless you want >> to be able to run this without KUnit configured >> >> - add the test script under selftests - the script then can load the >> test driver and run tests and unload the driver. >> > > Thanks Shuah. We would like to introduce more CPU benchmark testing based > the amd-pstate-ut next step, it may not be all the stuff in the kernel > module. E.X. use the script to trigger the tbench, gitsource, kernbench, > netperf, speedometer, and etc. testing and monitor the cpu frequency and > performance goals change, power consumption at runtime. Can the KUnit + > Kselftests work more straight forward in user scenario? >
I am not sure if I understand your question. Also I am not sure if understand the scope of the testing you are intending to do using amd-pstate-ut.
tbench, gitsource etc. are external tests (meaning not in kernel repo). Do these tests depend on amd-pstate-ut?
It would be helpful to understand the scope first. What exactly will amd-pstate-ut used for? Based on the patch series it looked like:
-- amd-pstate-ut has unit test code which will be triggered from kselftest
This is perfectly fine. The driver can reside under drivers/cpufreq and a test.sh can reside under selftests. It can just use kselftest framework.
Based on what you are saying. kselftest might be a good choice.
thanks, -- Shuah
| |