Messages in this thread | | | From | "Lad, Prabhakar" <> | Date | Wed, 18 May 2022 20:46:20 +0100 | Subject | Re: [PATCH -next 3/3] media: isif: remove unnecessary check of res |
| |
On Tue, Apr 26, 2022 at 3:53 AM Yang Yingliang <yangyingliang@huawei.com> wrote: > > The resource is checked in probe function, so there is > no need do this check in remove function. > > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> > --- > drivers/media/platform/ti/davinci/isif.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > Reviewed-by: Lad Prabhakar <prabhakar.csengg@gmail.com>
Cheers, Prabhakar
> diff --git a/drivers/media/platform/ti/davinci/isif.c b/drivers/media/platform/ti/davinci/isif.c > index c53cecd072b1..69e862de014f 100644 > --- a/drivers/media/platform/ti/davinci/isif.c > +++ b/drivers/media/platform/ti/davinci/isif.c > @@ -1107,8 +1107,7 @@ static int isif_remove(struct platform_device *pdev) > isif_cfg.linear_tbl1_addr = NULL; > while (i < 3) { > res = platform_get_resource(pdev, IORESOURCE_MEM, i); > - if (res) > - release_mem_region(res->start, resource_size(res)); > + release_mem_region(res->start, resource_size(res)); > i++; > } > vpfe_unregister_ccdc_device(&isif_hw_dev); > -- > 2.25.1 >
| |