Messages in this thread | | | From | "Lad, Prabhakar" <> | Date | Wed, 18 May 2022 20:39:47 +0100 | Subject | Re: [PATCH] media: davinci: vpif: add missing of_node_put() in vpif_probe() |
| |
On Wed, May 11, 2022 at 7:44 AM Yang Yingliang <yangyingliang@huawei.com> wrote: > > of_graph_get_next_endpoint() returns an 'endpoint' node pointer > with refcount incremented. The refcount should be decremented > before returning from vpif_probe(). > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> > --- > drivers/media/platform/ti/davinci/vpif.c | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Lad Prabhakar <prabhakar.csengg@gmail.com>
Cheers, Prabhakar
> diff --git a/drivers/media/platform/ti/davinci/vpif.c b/drivers/media/platform/ti/davinci/vpif.c > index 97ef770266af..da27da4c165a 100644 > --- a/drivers/media/platform/ti/davinci/vpif.c > +++ b/drivers/media/platform/ti/davinci/vpif.c > @@ -469,6 +469,7 @@ static int vpif_probe(struct platform_device *pdev) > endpoint); > if (!endpoint) > return 0; > + of_node_put(endpoint); > > /* > * For DT platforms, manually create platform_devices for > -- > 2.25.1 >
| |