Messages in this thread | | | From | Martin Blumenstingl <> | Date | Wed, 18 May 2022 19:58:58 +0200 | Subject | Re: [PATCH net v1 1/2] net: dsa: lantiq_gswip: Fix start index in gswip_port_fdb() |
| |
Hi Vladimir,
On Wed, May 18, 2022 at 1:45 PM Vladimir Oltean <olteanv@gmail.com> wrote: [...] > The patch, as well as other improvements you might want to bring to the gswip driver > (we have more streamlined support in DSA now for FDB isolation, see ds->fdb_isolation) > is appreciated. Thank you very much for this hint! I was not aware of the ds->fdb_isolation flag and additionally I have some other questions regarding FDB - I'll send these in a separate email though. Also thank you for being quick to review my patches and on top of that providing extra hints!
> But I don't think that a code cleanup patch that makes no functional > difference, and isn't otherwise needed by other backported patches, > should be sent to the "net" tree, and be backported to "stable" later? Sure, I will actually re-send the whole series based on net-next. When I initially wrote this patch I thought that it would fix a more severe issue. Only later on I found that the bug is harmless (as mentioned in the patch description). When I then finally sent the patch I just stuck with my original plan to send it for the net.git tree - instead of re-thinking whether that's still needed after my latest findings.
Best regards, Martin
| |