Messages in this thread | | | Date | Tue, 17 May 2022 12:32:39 -0300 | Subject | Re: [PATCH 15/30] bus: brcmstb_gisb: Clean-up panic/die notifiers | From | "Guilherme G. Piccoli" <> |
| |
On 10/05/2022 12:28, Petr Mladek wrote: > [...] > IMHO, the check of the @self parameter was the proper solution. > > "gisb_die_notifier" list uses @val from enum die_val. > "gisb_panic_notifier" list uses @val from enum panic_notifier_val. > > These are unrelated types. It might easily break when > someone defines the same constant also in enum die_val. > > Best Regards, > Petr
OK Petr, I'll drop this idea for V2 - will just remove the useless header / prototype then. (CC Florian)
Cheers,
Guilherme
| |