Messages in this thread | | | From | Neal Liu <> | Subject | RE: [PATCH v2 2/3] ARM: dts: aspeed: Add USB2.0 device controller node | Date | Tue, 17 May 2022 15:32:15 +0000 |
| |
> -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: Tuesday, May 17, 2022 11:26 PM > To: Neal Liu <neal_liu@aspeedtech.com>; Greg Kroah-Hartman > <gregkh@linuxfoundation.org>; Rob Herring <robh+dt@kernel.org>; Krzysztof > Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Joel Stanley <joel@jms.id.au>; > Andrew Jeffery <andrew@aj.id.au>; Felipe Balbi <balbi@kernel.org>; Sumit > Semwal <sumit.semwal@linaro.org>; Christian König > <christian.koenig@amd.com>; Geert Uytterhoeven <geert@linux-m68k.org>; > Li Yang <leoyang.li@nxp.com> > Cc: linux-aspeed@lists.ozlabs.org; linux-usb@vger.kernel.org; > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > linux-kernel@vger.kernel.org; linux-media@vger.kernel.org; > dri-devel@lists.freedesktop.org; linaro-mm-sig@lists.linaro.org > Subject: Re: [PATCH v2 2/3] ARM: dts: aspeed: Add USB2.0 device controller > node > > On 17/05/2022 17:21, Neal Liu wrote: > >>>>> > >>>>> + udc: udc@1e6a2000 { > >>>> > >>>> The same as DTS in bindings - generic node name, please. > >>>> > >>> > >>> Is it possible to use "udc: usb-udc@1e6a2000" to distinguish it between > "vhub: > >> usb-vhub@1e6a0000"? > >> > >> Possible yes :), but not recommended and not wanted. Nodes should be > >> generic and prefixes are added only if there is no unit address. You > >> can though use some more descriptive label. > >> > > "udc: usb@1e6a2000" is okay for you? > > Yes, it's perfect.
Great ! I'll update it for next patch. Thanks for your suggestion. > > > Best regards, > Krzysztof
| |