Messages in this thread | | | Date | Tue, 17 May 2022 20:37:17 +0530 | Subject | Re: [PATCH v8 1/2] dt-bindings: thermal: k3-j72xx: Add VTM bindings documentation | From | "J, KEERTHY" <> |
| |
On 5/17/2022 8:08 PM, Krzysztof Kozlowski wrote: > On 17/05/2022 14:14, Keerthy wrote: >> Add VTM bindings documentation. In the Voltage Thermal >> Management Module(VTM), K3 J72XX supplies a voltage >> reference and a temperature sensor feature that are gathered in the band >> gap voltage and temperature sensor (VBGAPTS) module. The band >> gap provides current and voltage reference for its internal >> circuits and other analog IP blocks. The analog-to-digital >> converter (ADC) produces an output value that is proportional >> to the silicon temperature. >> >> Signed-off-by: Keerthy <j-keerthy@ti.com> > > It seems I am repeating myself... Tags are still missing...
I still do not have a Reviewed-by from you. Should i add yours? You are still giving additional comments so I did not add.
> >> + >> +examples: >> + - | >> + #include <dt-bindings/soc/ti,sci_pm_domain.h> >> + wkup_vtm0: thermal-sensor@42040000 { >> + compatible = "ti,j721e-vtm"; >> + reg = <0x42040000 0x350>, >> + <0x42050000 0x350>, >> + <0x43000300 0x10>; > > Please align the continued entries with opening <.
Okay. I will fix that.
> >> + power-domains = <&k3_pds 154 TI_SCI_PD_EXCLUSIVE>; >> + #thermal-sensor-cells = <1>; >> + }; >> + >> + mpu_thermal: mpu-thermal { >> + polling-delay-passive = <250>; /* milliseconds */ >> + polling-delay = <500>; /* milliseconds */ >> + thermal-sensors = <&wkup_vtm0 0>; >> + >> + trips { >> + mpu_crit: mpu-crit { > > You still have here incorrect/inconsistent indentation. Entire DTS > example goes usually with 4 spaces.
Okay.
> >> + temperature = <125000>; /* milliCelsius */ >> + hysteresis = <2000>; /* milliCelsius */ >> + type = "critical"; >> + }; >> + }; >> + }; >> +... > >
Thanks, Keerthy
> Best regards, > Krzysztof
| |