lkml.org 
[lkml]   [2022]   [May]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 2/6] dt-bindings: arm: mt8186: Set #clock-cells as required property
    From
    On 17/05/2022 12:15, AngeloGioacchino Del Regno wrote:
    > This is a clock-controller binding, so it needs #clock-cells, or
    > it would be of no use: add that to the list of required properties.
    >
    > Fixes: f113a51aa2cf ("dt-bindings: ARM: MediaTek: Add new document bindings of MT8186 clock")
    > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
    > ---
    > .../devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml | 1 +

    If these are clock controllers and new bindings, why they were added to
    "arm" directory? arm is only for top-level stuff, not for devices.

    In the future please put your bindings in respective subsystem matching
    the hardware. Fallback is soc directory, not arm.

    Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

    Best regards,
    Krzysztof

    \
     
     \ /
      Last update: 2022-05-17 16:34    [W:3.361 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site