Messages in this thread | | | Date | Tue, 17 May 2022 15:33:13 +0100 | From | "Russell King (Oracle)" <> | Subject | Re: [PATCH 1/3] ARM: Kconfig: Fix indentation and add comments |
| |
Hi,
On Tue, May 17, 2022 at 04:14:22PM +0200, Juerg Haefliger wrote: > The convention for indentation seems to be a single tab. Help text is > further indented by an additional two whitespaces. Fix the lines that > violate these rules. > > While add it, add trailing comments to endif and endmenu statements for > better readability.
I have never been a fan of that practice, but I understand that some people really like it. At the end of the day, it's subjective, so let's leave it as-is for the time being.
The other changes are worth having though. Please send a patch making just those changes.
Thanks.
-- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
| |