Messages in this thread | | | Date | Tue, 17 May 2022 16:23:30 +0200 | From | Marc Kleine-Budde <> | Subject | Re: [PATCH v3 3/4] can: skb:: move can_dropped_invalid_skb and can_skb_headroom_valid to skb.c |
| |
On 17.05.2022 15:43:01, Max Staudt wrote: > > Oh, I didn't want to introduce two new kernel modules but to have > > can_dev in different 'feature levels'. > > Which I agree is a nice idea, as long as heisenbugs can be avoided :) > > (as for the separate modules vs. feature levels of can-dev - sorry, my > two paragraphs were each referring to a different idea. I mixed them > into one single email...) > > Maybe the can-skb and rx-offload parts could be a *visible* sub-option > of can-dev in Kconfig, which is normally optional, but immediately > force-selected once a CAN HW driver is selected?
In the ctucanfd driver we made the base driver "invisible" if COMPILE_TEST is not selected:
| config CAN_CTUCANFD | tristate "CTU CAN-FD IP core" if COMPILE_TEST | | config CAN_CTUCANFD_PCI | tristate "CTU CAN-FD IP core PCI/PCIe driver" | depends on PCI | select CAN_CTUCANFD
regards, Marc
-- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | [unhandled content-type:application/pgp-signature] | |