Messages in this thread | | | Date | Tue, 17 May 2022 16:08:55 +0200 | Subject | Re: [PATCH v2 2/2] nvmem: microchip-otpc: add support | From | Krzysztof Kozlowski <> |
| |
On 17/05/2022 14:58, Claudiu Beznea wrote:
Thank you for your patch. There is something to discuss/improve.
> +static const struct of_device_id mchp_otpc_ids[] = { > + { .compatible = "microchip,sama7g5-otpc", }, > + { }, > +}; > +MODULE_DEVICE_TABLE(of, mchp_otpc_ids); > + > +static struct platform_driver mchp_otpc_driver = { > + .probe = mchp_otpc_probe, > + .driver = { > + .name = MCHP_OTPC_NAME, > + .of_match_table = of_match_ptr(mchp_otpc_ids),
This still has incorrect pair of of_match_ptr/maybe_unused. Either both, or none.
Best regards, Krzysztof
| |