Messages in this thread | | | Date | Tue, 17 May 2022 10:03:15 -0400 | Subject | Re: [PATCH v1] drm/scheduler: Don't kill jobs in interrupt context | From | Andrey Grodzovsky <> |
| |
Let me push it into drm-misc-next.
Andrey
On 2022-05-17 05:03, Dmitry Osipenko wrote:
> On 5/17/22 10:40, Erico Nunes wrote: >> On Wed, Apr 13, 2022 at 12:05 PM Steven Price <steven.price@arm.com> wrote: >>> On 11/04/2022 23:15, Dmitry Osipenko wrote: >>>> Interrupt context can't sleep. Drivers like Panfrost and MSM are taking >>>> mutex when job is released, and thus, that code can sleep. This results >>>> into "BUG: scheduling while atomic" if locks are contented while job is >>>> freed. There is no good reason for releasing scheduler's jobs in IRQ >>>> context, hence use normal context to fix the trouble. >>>> >>>> Cc: stable@vger.kernel.org >>>> Fixes: 542cff7893a3 ("drm/sched: Avoid lockdep spalt on killing a processes") >>>> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com> >>> Reviewed-by: Steven Price <steven.price@arm.com> >> Is there something blocking this patch? >> Mesa CI is still hitting the issue and I have been waiting for it to >> be applied/backported to update CI with it. >> Thanks > If this patch won't be picked up anytime soon, then I'll include it into > my "memory shrinker" patchset together with the rest of the fixes, so it > won't get lost. >
| |