lkml.org 
[lkml]   [2022]   [May]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] phy: qcom: fix missing clk_disable_unprepare() on err in qcom_pcie2_phy_power_on
Date
Fix the missing clk_disable_unprepare() before return
from qcom_pcie2_phy_power_on() in the error handling case.

Signed-off-by: Peng Wu <wupeng58@huawei.com>
---
drivers/phy/qualcomm/phy-qcom-pcie2.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/phy/qualcomm/phy-qcom-pcie2.c b/drivers/phy/qualcomm/phy-qcom-pcie2.c
index 5407e59bb185..1cc8145e0811 100644
--- a/drivers/phy/qualcomm/phy-qcom-pcie2.c
+++ b/drivers/phy/qualcomm/phy-qcom-pcie2.c
@@ -162,8 +162,10 @@ static int qcom_pcie2_phy_power_on(struct phy *phy)

ret = readl_poll_timeout(qphy->base + PCIE20_PARF_PHY_STTS, val,
!(val & BIT(0)), 1000, 10);
- if (ret)
+ if (ret) {
+ clk_disable_unprepare(qphy->pipe_clk);
dev_err(qphy->dev, "phy initialization failed\n");
+ }

out:
return ret;
--
2.17.1
\
 
 \ /
  Last update: 2022-05-17 15:07    [W:3.168 / U:0.616 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site