lkml.org 
[lkml]   [2022]   [May]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] fs/ntfs: remove redundant variable idx
Date
Hi Andrew,

Please could you merge this? Thanks a lot!

Best regards,

Anton

> On 17 May 2022, at 10:36, Colin Ian King <colin.i.king@gmail.com> wrote:
>
> The variable idx is assigned a value and is never read. The variable
> is not used and is redundant, remove it.
>
> Cleans up clang scan build warning:
> warning: Although the value stored to 'idx' is used in the enclosing
> expression, the value is never actually read from 'idx'
> [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Reviewed-by: Anton Altaparmakov <anton@tuxera.com>
> ---
> fs/ntfs/file.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/ntfs/file.c b/fs/ntfs/file.c
> index e1392a9b8ceb..a8abe2296514 100644
> --- a/fs/ntfs/file.c
> +++ b/fs/ntfs/file.c
> @@ -1772,11 +1772,11 @@ static ssize_t ntfs_perform_write(struct file *file, struct iov_iter *i,
> last_vcn = -1;
> do {
> VCN vcn;
> - pgoff_t idx, start_idx;
> + pgoff_t start_idx;
> unsigned ofs, do_pages, u;
> size_t copied;
>
> - start_idx = idx = pos >> PAGE_SHIFT;
> + start_idx = pos >> PAGE_SHIFT;
> ofs = pos & ~PAGE_MASK;
> bytes = PAGE_SIZE - ofs;
> do_pages = 1;
> --
> 2.35.1
>

\
 
 \ /
  Last update: 2022-05-17 14:11    [W:0.045 / U:1.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site