Messages in this thread | | | From | Khazhy Kumykov <> | Date | Mon, 16 May 2022 23:27:09 -0700 | Subject | Re: [RESEND][RFC PATCH] blkcg: rewind seq_file if no stats |
| |
On Mon, May 16, 2022 at 11:12 PM Christoph Hellwig <hch@lst.de> wrote: > > On Fri, May 13, 2022 at 10:40:30AM -0700, Khazhismel Kumykov wrote: > > Restores the previous behavior of only displaying devices for which we > > have statistics (and removes the current, broken, behavior of printing > > devname with no newline if no statistics) > > > > In lieu of get_seq_buf + seq_commit, provide a way to "undo" writes if > > we use seq_printf > > I have to say I much prefer the simpler fix from Wolfgang. But Wolfgang's fix still results in a change in behavior, and in my opinion a worse behavior - we don't need to print out the device names if there are no stats.
> if we want to go down this route it needs to split into a patch > for the seq_file infrastruture and a separate one for the blk-cgroup > code. Of course - I can spin this into a series if we think it's worthwhile [unhandled content-type:application/pkcs7-signature] | |