Messages in this thread | | | Date | Tue, 17 May 2022 12:06:57 +0200 | From | Greg KH <> | Subject | Re: [PATCH 1/1] staging: fix a potential infinite loop |
| |
On Tue, May 17, 2022 at 05:58:09PM +0800, Yuanjun Gong wrote: > From: Gong Yuanjun <ruc_gongyuanjun@163.com> > > In the for-loop in _rtl92e_update_rxcounts(), > i is a u8 counter while priv->rtllib->LinkDetectInfo.SlotNum is > a u16 num, there is a potential infinite loop if SlotNum is larger > than u8_max. > > Change the u8 loop counter i into u16. > > Signed-off-by: Gong Yuanjun <ruc_gongyuanjun@163.com> > --- > drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c > index b9ce71848023..3c5082abc583 100644 > --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c > +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c > @@ -1342,7 +1342,7 @@ static void _rtl92e_update_rxcounts(struct r8192_priv *priv, u32 *TotalRxBcnNum, > u32 *TotalRxDataNum) > { > u16 SlotIndex; > - u8 i; > + u16 i; > > *TotalRxBcnNum = 0; > *TotalRxDataNum = 0; > -- > 2.17.1 >
<formletter>
This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly.
</formletter>
| |