lkml.org 
[lkml]   [2022]   [May]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] objtool: fix objtool regression on x32 systems
On Tue, May 17, 2022 at 08:26:42AM +0000, David Laight wrote:
> From: Peter Zijlstra
> > Sent: 16 May 2022 22:25
> ...
> > A quick look seems to suggest at least all the 'offset' fields should be
> > u64 or something. The only reason that works is because -mcmodel=kernel
> > keeps everything in the 2G range to make s32 immediates work. But it
> > isn't right.
>
> Offsets in instructions are only 8bit or 32bit.
> The mod/reg/rm and SiB encodings don't support anything else.
> If offsets might be large then they have to be loaded into
> registers - which will slow things down.

Not relevant; these are Elf64_Addr fields, objtool currently uses
'unsigned long' for them, but that goes sideways if ILP32.

\
 
 \ /
  Last update: 2022-05-17 11:45    [W:0.083 / U:0.296 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site