Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Tue, 17 May 2022 09:48:07 +0200 | Subject | Re: [PATCH] pinctrl: renesas: pinctrl-rzg2l: Return -EINVAL for pins which have input disabled |
| |
On Wed, May 11, 2022 at 11:41 AM Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > Pin status reported by pinconf-pins file always reported pin status as > "input enabled" even for pins which had input disabled. Fix this by > returning -EINVAL for the pins which have input disabled. > > Fixes: c4c4637eb57f2 ("pinctrl: renesas: Add RZ/G2L pin and gpio controller driver") > Reported-by: Phil Edworthy <phil.edworthy@renesas.com> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Nice catch!
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> i.e. will queue in renesas-pinctrl-for-v5.20.
BTW, several other (non-Renesas) drivers seem to get this wrong, too.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |