Messages in this thread | | | Date | Wed, 18 May 2022 10:44:05 +0800 | Subject | Re: [PATCH 2/4] dmaengine: sprd-dma: Remove unneeded ERROR check before clk_disable_unprepare | From | Jiabing Wan <> |
| |
Hi,
On 2022/5/17 23:13, Krzysztof Kozlowski wrote: > On 16/05/2022 10:41, Wan Jiabing wrote: >> clk_disable_unprepare() already checks ERROR by using IS_ERR_OR_NULL. > Hmm, maybe I am looking at different sources, but which commit > introduced IS_ERR_OR_NULL() check? Where is it in the sources? > In commit 4dff95dc9477a, IS_ERR_OR_NULL check is added in clk_disable() and clk_unprepare(). And clk_disable_unprepare() just calls clk_disable() and clk_unprepare():
static inline void clk_disable_unprepare(struct clk *clk) { clk_disable(clk); clk_unprepare(clk); } > > Best regards, > Krzysztof
Thanks, Wan Jiabing
| |