Messages in this thread | | | Date | Tue, 17 May 2022 17:55:19 -0700 | From | Jakub Kicinski <> | Subject | Re: [PATCH] sfc/siena: fix driver suspend/resume methods |
| |
On Tue, 17 May 2022 01:23:34 +0000 Peng Wu wrote: > Fix the missing pci_disable_device() before return > from efx_pm_resume() in the error handling case. > > Meanwhile, drivers should do this: > .resume() > pci_enable_device() > .suspend() > pci_disable_device() > > Signed-off-by: Peng Wu <wupeng58@huawei.com>
Won't the remove function no disable the device, anyway?
If the patch is indeed needed please add a Fixes tag pointing to where the buggy code was added and repost.
Also since this file is a copy of drivers/net/ethernet/sfc/efx.c I'm not sure why you're only patching this instance but not the original.
| |