Messages in this thread | | | From | Song Liu <> | Subject | Re: [PATCH bpf-next 2/5] x86/alternative: introduce text_poke_set | Date | Tue, 17 May 2022 21:09:57 +0000 |
| |
> On May 17, 2022, at 12:16 PM, Edgecombe, Rick P <rick.p.edgecombe@intel.com> wrote: > > On Sun, 2022-05-15 at 22:40 -0700, Song Liu wrote: >> +static void text_poke_memset(void *dst, const void *src, size_t len) >> +{ >> + int c = *(int *)src; > > It casts away the const unnecessarily. It could be *(const int *)src.
I will fix this in the next version. Or we can ask the maintainer to fix it when applying the patches.
Thanks, Song
> >> + >> + memset(dst, c, len); >> +} >> +
| |