Messages in this thread | | | Date | Tue, 17 May 2022 15:12:25 -0300 | Subject | Re: [PATCH 21/30] panic: Introduce the panic pre-reboot notifier list | From | "Guilherme G. Piccoli" <> |
| |
On 17/05/2022 14:02, Luck, Tony wrote: >> Tony / Dinh - can I just *skip* this notifier *if kdump* is set or else >> we run the code as-is? Does that make sense to you? > > The "skip" option sounds like it needs some special flag associated with > an entry on the notifier chain. But there are other notifier chains ... so that > sounds messy to me. > > Just all the notifiers in priority order. If any want to take different actions > based on kdump status, change the code. That seems more flexible than > an "all or nothing" approach by skipping. > > -Tony
I guess I've expressed myself in a poor way - sorry!
What I'm planning to do in the altera_edac notifier is:
if (kdump_is_set) return;
/* regular code */
In other words: if the kdump is set, this notifier will be effectively a nop (although it's gonna be called).
Lemme know your thoughts Tony, if that makes sense. Thanks,
Guilherme
| |