Messages in this thread | | | From | Sami Tolvanen <> | Date | Mon, 16 May 2022 09:32:27 -0700 | Subject | Re: [RFC PATCH v2 14/21] treewide: Drop __cficanonical |
| |
On Sat, May 14, 2022 at 2:56 PM Kees Cook <keescook@chromium.org> wrote: > > On Fri, May 13, 2022 at 01:21:52PM -0700, Sami Tolvanen wrote: > > CONFIG_CFI_CLANG doesn't use a jump table anymore and therefore, > > won't change function references to point elsewhere. Remove the > > __cficanonical attribute and all uses of it. > > > > Signed-off-by: Sami Tolvanen <samitolvanen@google.com> > > --- > > include/linux/compiler_types.h | 4 ---- > > include/linux/init.h | 4 ++-- > > include/linux/pci.h | 4 ++-- > > 3 files changed, 4 insertions(+), 8 deletions(-) > > I think this is missing removing it from include/linux/compiler-clang.h ?
That was removed in the earlier patch that switched the CFI implementation.
> With that done (or explained why not):
I'll add a note about it to the commit message.
Sami
| |