lkml.org 
[lkml]   [2022]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 08/12] dt-bindings: remoteproc: qcom,smd-edge: define re-usable schema for smd-edge
On Thu, May 12, 2022 at 12:00:02PM +0200, Krzysztof Kozlowski wrote:
> 'smd-edge' property appears in multiple bindings, so split it into one
> place which can be re-used. This reduces code duplication and strict
> schema matching for smd-edge nodes (instead of just "type:object").
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../bindings/remoteproc/qcom,adsp.yaml | 2 +-
> .../bindings/remoteproc/qcom,smd-edge.yaml | 88 +++++++++++++++++++
> .../bindings/soc/qcom/qcom,smd.yaml | 53 +----------
> 3 files changed, 91 insertions(+), 52 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,smd-edge.yaml
>
> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
> index 4dfbfece1ec7..3072af5f9d79 100644
> --- a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
> @@ -148,7 +148,7 @@ properties:
> three offsets within syscon for q6, modem and nc halt registers.
>
> smd-edge:
> - type: object
> + $ref: /schemas/remoteproc/qcom,smd-edge.yaml#
> description:
> Qualcomm Shared Memory subnode which represents communication edge,
> channels and devices related to the ADSP.
> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,smd-edge.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,smd-edge.yaml
> new file mode 100644
> index 000000000000..fde2c450e8b5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,smd-edge.yaml
> @@ -0,0 +1,88 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/remoteproc/qcom,smd-edge.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm SMD Edge communication channel nodes
> +
> +maintainers:
> + - Bjorn Andersson <bjorn.andersson@linaro.org>
> +
> +description:
> + Qualcomm SMD subnode represents a remote subsystem or a remote processor of
> + some sort - or in SMD language an "edge". The name of the edges are not
> + important.
> +
> +
> + See also Documentation/devicetree/bindings/soc/qcom/qcom,smd.yaml
> +
> +properties:
> + $nodename:
> + const: "smd-edge"
> +
> + interrupts:
> + maxItems: 1
> +
> + label:
> + $ref: /schemas/types.yaml#/definitions/string

Don't need a type here. Otherwise,

Reviewed-by: Rob Herring <robh@kernel.org>

\
 
 \ /
  Last update: 2022-05-16 17:26    [W:0.102 / U:0.424 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site