Messages in this thread Patch in this message |  | | From | Anssi Hannula <> | Subject | [PATCH 04/12] can: kvaser_usb: Mark Mini PCIe 2xHS as supporting error counters | Date | Mon, 16 May 2022 16:47:40 +0300 |
| |
The 0bfd:0124 Kvaser Mini PCI Express 2xHS (FW 4.18.778) seems to support TX/RX error counters in exactly the same way (via unsolicited cmd 106 on bus errors and via cmd 20 when queried with cmd 19) as 0bfd:0017 Kvaser Memorator Professional HS/HS (FW 2.0.50), but only the latter has KVASER_USB_HAS_TXRX_ERRORS set to enable do_get_berr_counter().
Enable error counter retrieval for Kvaser Mini PCI Express 2xHS, too.
Fixes: 71873a9b38d1 ("can: kvaser_usb: Add support for more Kvaser Leaf v2 devices") Signed-off-by: Anssi Hannula <anssi.hannula@bitwise.fi>
---
I'm not really sure what KVASER_USB_HAS_TXRX_ERRORS means, exactly, w.r.t. device behavior, though, i.e. how does a device without it behave.
drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c b/drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c index 47bff40c36b6..7388fdca9079 100644 --- a/drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c +++ b/drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c @@ -165,7 +165,8 @@ static const struct usb_device_id kvaser_usb_table[] = { { USB_DEVICE(KVASER_VENDOR_ID, USB_MINI_PCIE_HS_PRODUCT_ID) }, { USB_DEVICE(KVASER_VENDOR_ID, USB_LEAF_LIGHT_HS_V2_OEM_PRODUCT_ID) }, { USB_DEVICE(KVASER_VENDOR_ID, USB_USBCAN_LIGHT_2HS_PRODUCT_ID) }, - { USB_DEVICE(KVASER_VENDOR_ID, USB_MINI_PCIE_2HS_PRODUCT_ID) }, + { USB_DEVICE(KVASER_VENDOR_ID, USB_MINI_PCIE_2HS_PRODUCT_ID), + .driver_info = KVASER_USB_HAS_TXRX_ERRORS }, { USB_DEVICE(KVASER_VENDOR_ID, USB_USBCAN_R_V2_PRODUCT_ID) }, { USB_DEVICE(KVASER_VENDOR_ID, USB_LEAF_LIGHT_R_V2_PRODUCT_ID) }, { USB_DEVICE(KVASER_VENDOR_ID, USB_LEAF_LIGHT_HS_V2_OEM2_PRODUCT_ID) }, -- 2.34.1
|  |