Messages in this thread | | | Date | Mon, 16 May 2022 13:51:26 +0300 | From | Vladimir Oltean <> | Subject | Re: [RFC Patch net-next v2 2/9] net: dsa: microchip: move ksz_chip_data to ksz_common |
| |
On Fri, May 13, 2022 at 03:52:12PM +0530, Arun Ramadoss wrote: > This patch moves the ksz_chip_data in ksz8795 and ksz9477 to ksz_common. > At present, the dev->chip_id is iterated with the ksz_chip_data and then > copy its value to the ksz_dev structure. These values are declared as > constant. > Instead of copying the values and referencing it, this patch update the > dev->info to the ksz_chip_data based on the chip_id in the init > function. And also update the ksz_chip_data values for the LAN937x based > switches. > > Signed-off-by: Arun Ramadoss <arun.ramadoss@microchip.com> > ---
Thanks, this looks good. I see that dev->info is assigned in ksz_switch_register and I had to look to see whether there is any dev->info dereference from before the call to ksz_switch_register(), and it looks like we're ok.
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
| |