lkml.org 
[lkml]   [2022]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v12 4/7] mm: hotplug: introduce SECTION_CANNOT_OPTIMIZE_VMEMMAP
On Mon, May 16, 2022 at 06:22:08PM +0800, Muchun Song wrote:
> --- a/mm/sparse.c
> +++ b/mm/sparse.c
> @@ -913,6 +913,13 @@ int __meminit sparse_add_section(int nid, unsigned long start_pfn,
> ms = __nr_to_section(section_nr);
> set_section_nid(section_nr, nid);
> __section_mark_present(ms, section_nr);
> + /*
> + * Mark whole section as non-optimizable once there is a subsection
> + * whose vmemmap pages are allocated from alternative allocator. The
> + * early section is always optimizable.
> + */
> + if (!early_section(ms) && altmap)
> + section_mark_cannot_optimize_vmemmap(ms);

Because no one expects those sections to be removed?
IIRC, early_section + altmap only happened in case of sub-section pmem
scenario? I guess my question is: can we really have early_sections coming
from alternative allocator?

I think this should be spelled out more.


--
Oscar Salvador
SUSE Labs

\
 
 \ /
  Last update: 2022-05-16 12:39    [W:0.131 / U:0.692 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site