Messages in this thread | | | From | Kun-Fa Lin <> | Date | Tue, 17 May 2022 09:55:52 +0800 | Subject | Re: [PATCH v2 1/5] arm: dts: Add node for NPCM Video Capture/Encode Engine |
| |
Dear Paul,
Thanks for your review and comments.
> Could you please add the datasheet name and revision to the commit message?
It may not be appropriate since the datasheet is not public.
> What board did you test this on?
I tested on Nuvoton NPCM750 evaluation board.
> > > Signed-off-by: Marvin Lin <kflin@nuvoton.com> > > As you sent this from your Google Mail account, that address is going to > be used in the author field. Is your Nuvoton address configured for git? > > git config user.email > > Then I would have thought, that that address is also in the files > generated by `git format-patch`.
Thanks for the reminder. I'll change the address configuration.
Regards, Marvin
| |