lkml.org 
[lkml]   [2022]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 2/2] ARM: dts: sun8i-r40: Add "cpu-supply" node for sun8i-r40 based board
On Fri, May 13, 2022 at 04:23:20PM +0800, qianfan wrote:
> > > > There's a similar issue for all the boards that don't have a regulator
> > > > in the first place.
> > > >
> > > > The way we worked around this for the other SoCs is to have a DTSI with
> > > > the OPPs with a frequency higher than what U-Boot boots with (1008MHz?),
> > > > and only include that DTSI on boards that have a CPU regulator hooked in.
> > > Is this really necessary? It seems like every board based on sun8i-r40
> > > have a cpu regulator.
> > This probably won't be the case whenever someone starts a new design,
> > and then they'll face random crashes for no apparent reason, and waste a
> > lot of time in the process.
> >
> > Whereas the alternative is that you would be missing some OPPs,
> > something that is fairly easy to figure out.
>
> How about remove the OPPs which greate that 1.08G in sun8i-r40.dtsi,
> If some boards want to run at a higher frequency, can add them byself
> in the board's file.

You did all the work to support and test them already. It's a bit of a
waste to do that and not include it.

Just do a DTSI like we did for the A64 for example.

Maxime

\
 
 \ /
  Last update: 2022-05-16 09:55    [W:0.038 / U:0.788 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site