lkml.org 
[lkml]   [2022]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] kunit: fix executor OOM error handling logic on non-UML
On Fri, May 13, 2022 at 2:37 PM Daniel Latypov <dlatypov@google.com> wrote:
>
> The existing logic happens to work fine on UML, but is not correct when
> running on other arches.
>
> 1. We didn't initialize `int err`, and kunit_filter_suites() doesn't
> explicitly set it to 0 on success. So we had false "failures".
> Note: it doesn't happen on UML, causing this to get overlooked.
> 2. If we error out, we do not call kunit_handle_shutdown().
> This makes kunit.py timeout when using a non-UML arch, since the QEMU
> process doesn't ever exit.
>
> Fixes: a02353f49162 ("kunit: bail out of test filtering logic quicker if OOM")
> Signed-off-by: Daniel Latypov <dlatypov@google.com>

Reviewed-by: Brendan Higgins <brendanhiggins@google.com>

\
 
 \ /
  Last update: 2022-05-16 23:25    [W:0.032 / U:0.220 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site