lkml.org 
[lkml]   [2022]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] gpio: ftgpio: Remove unneeded ERROR check before clk_disable_unprepare
On Mon, May 16, 2022 at 10:50 AM Wan Jiabing <wanjiabing@vivo.com> wrote:
>
> clk_disable_unprepare() already checks ERROR by using IS_ERR_OR_NULL.
> Remove unneeded ERROR check for g->clk.
>
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
> drivers/gpio/gpio-ftgpio010.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpio/gpio-ftgpio010.c b/drivers/gpio/gpio-ftgpio010.c
> index b90a45c939a4..f422c3e129a0 100644
> --- a/drivers/gpio/gpio-ftgpio010.c
> +++ b/drivers/gpio/gpio-ftgpio010.c
> @@ -315,8 +315,8 @@ static int ftgpio_gpio_probe(struct platform_device *pdev)
> return 0;
>
> dis_clk:
> - if (!IS_ERR(g->clk))
> - clk_disable_unprepare(g->clk);
> + clk_disable_unprepare(g->clk);
> +
> return ret;
> }
>
> @@ -324,8 +324,8 @@ static int ftgpio_gpio_remove(struct platform_device *pdev)
> {
> struct ftgpio_gpio *g = platform_get_drvdata(pdev);
>
> - if (!IS_ERR(g->clk))
> - clk_disable_unprepare(g->clk);
> + clk_disable_unprepare(g->clk);
> +
> return 0;
> }
>
> --
> 2.36.1
>

Applied, thanks!

Bart

\
 
 \ /
  Last update: 2022-05-16 22:43    [W:0.104 / U:0.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site