lkml.org 
[lkml]   [2022]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v10 01/19] KVM: s390: pv: leak the topmost page table when destroy fails
From
Date
On Thu, 2022-04-14 at 10:02 +0200, Claudio Imbrenda wrote:

[...]
> +/**
> + * s390_replace_asce - Try to replace the current ASCE of a gmap
> with
> + * another equivalent one.
> + * @gmap the gmap
> + *
> + * If the allocation of the new top level page table fails, the ASCE
> is not
> + * replaced.
> + * In any case, the old ASCE is always removed from the list.
> Therefore the
> + * caller has to make sure to save a pointer to it beforehands,
> unless an
> + * intentional leak is intended.
> + */
> +int s390_replace_asce(struct gmap *gmap)
> +{
>
[...]
> +       /* Set new table origin while preserving existing ASCE
> control bits */
> +       asce = (gmap->asce & ~_ASCE_ORIGIN) | __pa(table);
> +       WRITE_ONCE(gmap->asce, asce);

Can someone concurrently touch the control bits?

\
 
 \ /
  Last update: 2022-05-16 09:23    [W:0.249 / U:0.376 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site