Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Mon, 16 May 2022 09:15:36 +0200 | Subject | Re: [PATCH] m68knommu: fix undefined reference to `mach_get_rtc_pll' |
| |
On Mon, May 16, 2022 at 8:08 AM Greg Ungerer <gerg@linux-m68k.org> wrote: > On 13/5/22 22:59, Arnd Bergmann wrote: > > On Fri, May 13, 2022 at 2:25 PM Greg Ungerer <gerg@linux-m68k.org> wrote: > >> On 13/5/22 17:12, Geert Uytterhoeven wrote: > >>> read_persistent_clock64() uses mach_hwclk(), which is provided by > >>> both setup_mm.c and setup_no.c, so it's always available?> Albeit not populated by coldfire or nommu platform code, so I see > >>> the point in depending on MMU (no nommu Amiga support yet ;-). > >> > >> Yes, exactly. And even worse is that on ColdFire platforms it > >> is never set, so will be the startup value of NULL. It is called > >> without checking for NULL in both of rtc_generic_get_time() and > >> rtc_generic_set_time(). > > > > I think that's ok because rtc_generic_{get,set}_time is only called > > from the rtc_generic driver, but that is not registered when mach_hwclk() > > is NULL. > > > > With your patch to add the CONFIG_MMU check, you can actually > > remove the mach_hwclk() symbol from setup_no.c, and move the > > remaining RTC related symbols from setup_mm.c into the #ifdef. > > Yes, I think that would be a good idea. > Tidies thins up a little.
Let's fix the build error first.
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |