lkml.org 
[lkml]   [2022]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 0/3] staging: r8188eu: fix checkpatch.pl warnings
From
Hi Vihas,

On 5/16/22 20:03, Vihas Makwana wrote:
> This patchset fixes following checkpatch warning:
> WARNING: Comparisons should place the constant on the right side of the test
>
> Compiled tested only.
>
> Vihas Makwana (3):
> staging: r8188eu: fix checkpatch warnings in rtw_p2p
> staging: r8188eu: fix checkpatch warnings in rtw_pwrctrl
> staging: r8188eu: fix checkpatch warnings in rtw_wlan_util
>
> drivers/staging/r8188eu/core/rtw_p2p.c | 8 ++++----
> drivers/staging/r8188eu/core/rtw_pwrctrl.c | 12 ++++++------
> drivers/staging/r8188eu/core/rtw_wlan_util.c | 2 +-
> 3 files changed, 11 insertions(+), 11 deletions(-)
>
checkpatch warns about the subjects. See an example for 1/3, but it's
related to all 3.

> WARNING: A patch subject line should describe the change not the tool that found it
> #4:
> Subject: [PATCH 1/3] staging: r8188eu: fix checkpatch.pl warnings in rtw_p2p
>
> total: 0 errors, 1 warnings, 0 checks, 32 lines checked




With regards,
Pavel Skripkin

\
 
 \ /
  Last update: 2022-05-16 22:16    [W:0.919 / U:0.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site