lkml.org 
[lkml]   [2022]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 33/66] ASoC: max98090: Generate notifications on changes for custom control
    Date
    From: Mark Brown <broonie@kernel.org>

    [ Upstream commit 13fcf676d9e102594effc686d98521ff5c90b925 ]

    The max98090 driver has some custom controls which share a put() function
    which returns 0 unconditionally, meaning that events are not generated
    when the value changes. Fix that.

    Signed-off-by: Mark Brown <broonie@kernel.org>
    Link: https://lore.kernel.org/r/20220420193454.2647908-2-broonie@kernel.org
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    sound/soc/codecs/max98090.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/sound/soc/codecs/max98090.c b/sound/soc/codecs/max98090.c
    index 779845e3a9e3..5b6405392f08 100644
    --- a/sound/soc/codecs/max98090.c
    +++ b/sound/soc/codecs/max98090.c
    @@ -430,7 +430,7 @@ static int max98090_put_enab_tlv(struct snd_kcontrol *kcontrol,
    mask << mc->shift,
    sel << mc->shift);

    - return 0;
    + return *select != val;
    }

    static const char *max98090_perf_pwr_text[] =
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-05-16 22:09    [W:2.096 / U:1.204 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site