Messages in this thread | | | Date | Mon, 16 May 2022 22:45:20 +0300 | Subject | Re: [PATCH 2/3] staging: r8188eu: fix checkpatch.pl warnings in rtw_pwrctrl | From | Pavel Skripkin <> |
| |
Hi Vihas,
On 5/16/22 20:03, Vihas Makwana wrote: > Refactor the code to fix following warnings: > WARNING: Comparisons should place the constant on the right side of the test > > Signed-off-by: Vihas Makwana <makvihas@gmail.com> > ---
[code snip]
> if ((pwrpriv->smart_ps == smart_ps) && > @@ -356,7 +356,7 @@ void rtw_init_pwrctrl_priv(struct adapter *padapter) > > pwrctrlpriv->LpsIdleCount = 0; > pwrctrlpriv->power_mgnt = padapter->registrypriv.power_mgnt;/* PS_MODE_MIN; */ > - pwrctrlpriv->bLeisurePs = PS_MODE_ACTIVE != pwrctrlpriv->power_mgnt; > + pwrctrlpriv->bLeisurePs = pwrctrlpriv->power_mgnt != PS_MODE_ACTIVE; >
Please remove extra space
With regards, Pavel Skripkin
| |