lkml.org 
[lkml]   [2022]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 13/43] s390/lcs: fix variable dereferenced before check
    Date
    From: Alexandra Winter <wintera@linux.ibm.com>

    [ Upstream commit 671bb35c8e746439f0ed70815968f9a4f20a8deb ]

    smatch complains about
    drivers/s390/net/lcs.c:1741 lcs_get_control() warn: variable dereferenced before check 'card->dev' (see line 1739)

    Fixes: 27eb5ac8f015 ("[PATCH] s390: lcs driver bug fixes and improvements [1/2]")
    Signed-off-by: Alexandra Winter <wintera@linux.ibm.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/s390/net/lcs.c | 7 ++++---
    1 file changed, 4 insertions(+), 3 deletions(-)

    diff --git a/drivers/s390/net/lcs.c b/drivers/s390/net/lcs.c
    index 8f08b0a2917c..4eec7bfb5de9 100644
    --- a/drivers/s390/net/lcs.c
    +++ b/drivers/s390/net/lcs.c
    @@ -1735,10 +1735,11 @@ lcs_get_control(struct lcs_card *card, struct lcs_cmd *cmd)
    lcs_schedule_recovery(card);
    break;
    case LCS_CMD_STOPLAN:
    - pr_warn("Stoplan for %s initiated by LGW\n",
    - card->dev->name);
    - if (card->dev)
    + if (card->dev) {
    + pr_warn("Stoplan for %s initiated by LGW\n",
    + card->dev->name);
    netif_carrier_off(card->dev);
    + }
    break;
    default:
    LCS_DBF_TEXT(5, trace, "noLGWcmd");
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-05-16 21:48    [W:2.675 / U:0.204 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site