lkml.org 
[lkml]   [2022]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 02/32] hwmon: (tmp401) Add OF device ID table
    Date
    From: Camel Guo <camel.guo@axis.com>

    [ Upstream commit 3481551f035725fdc46885425eac3ef9b58ae7b7 ]

    This driver doesn't have of_match_table. This makes the kernel module
    tmp401.ko lack alias patterns (e.g: of:N*T*Cti,tmp411) to match DT node
    of the supported devices hence this kernel module will not be
    automatically loaded.

    After adding of_match_table to this driver, the folllowing alias will be
    added into tmp401.ko.
    $ modinfo drivers/hwmon/tmp401.ko
    filename: drivers/hwmon/tmp401.ko
    ......
    author: Hans de Goede <hdegoede@redhat.com>
    alias: of:N*T*Cti,tmp435C*
    alias: of:N*T*Cti,tmp435
    alias: of:N*T*Cti,tmp432C*
    alias: of:N*T*Cti,tmp432
    alias: of:N*T*Cti,tmp431C*
    alias: of:N*T*Cti,tmp431
    alias: of:N*T*Cti,tmp411C*
    alias: of:N*T*Cti,tmp411
    alias: of:N*T*Cti,tmp401C*
    alias: of:N*T*Cti,tmp401
    ......

    Fixes: af503716ac14 ("i2c: core: report OF style module alias for devices registered via OF")
    Signed-off-by: Camel Guo <camel.guo@axis.com>
    Link: https://lore.kernel.org/r/20220503114333.456476-1-camel.guo@axis.com
    Signed-off-by: Guenter Roeck <linux@roeck-us.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/hwmon/tmp401.c | 11 +++++++++++
    1 file changed, 11 insertions(+)

    diff --git a/drivers/hwmon/tmp401.c b/drivers/hwmon/tmp401.c
    index 1f2d13dc9439..99b0d7e0a27a 100644
    --- a/drivers/hwmon/tmp401.c
    +++ b/drivers/hwmon/tmp401.c
    @@ -756,10 +756,21 @@ static int tmp401_probe(struct i2c_client *client,
    return 0;
    }

    +static const struct of_device_id __maybe_unused tmp4xx_of_match[] = {
    + { .compatible = "ti,tmp401", },
    + { .compatible = "ti,tmp411", },
    + { .compatible = "ti,tmp431", },
    + { .compatible = "ti,tmp432", },
    + { .compatible = "ti,tmp435", },
    + { },
    +};
    +MODULE_DEVICE_TABLE(of, tmp4xx_of_match);
    +
    static struct i2c_driver tmp401_driver = {
    .class = I2C_CLASS_HWMON,
    .driver = {
    .name = "tmp401",
    + .of_match_table = of_match_ptr(tmp4xx_of_match),
    },
    .probe = tmp401_probe,
    .id_table = tmp401_id,
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-05-16 21:45    [W:2.297 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site