lkml.org 
[lkml]   [2022]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] sched/rt: Support multi-criterion fitness search for
Hi Qais,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on tip/sched/core]
[also build test WARNING on v5.18-rc6 next-20220513]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/intel-lab-lkp/linux/commits/Qais-Yousef/sched-rt-Support-multi-criterion-fitness-search-for/20220515-075732
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 734387ec2f9d77b00276042b1fa7c95f48ee879d
config: arc-defconfig (https://download.01.org/0day-ci/archive/20220515/202205150843.y0w5RC5K-lkp@intel.com/config)
compiler: arc-elf-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/0eee64011b1d43795b5c8d1aa62927ba3f07a225
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Qais-Yousef/sched-rt-Support-multi-criterion-fitness-search-for/20220515-075732
git checkout 0eee64011b1d43795b5c8d1aa62927ba3f07a225
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=arc SHELL=/bin/bash kernel/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

In file included from kernel/sched/build_policy.c:45:
kernel/sched/rt.c:259:6: warning: no previous prototype for 'unregister_rt_sched_group' [-Wmissing-prototypes]
259 | void unregister_rt_sched_group(struct task_group *tg) { }
| ^~~~~~~~~~~~~~~~~~~~~~~~~
kernel/sched/rt.c:261:6: warning: no previous prototype for 'free_rt_sched_group' [-Wmissing-prototypes]
261 | void free_rt_sched_group(struct task_group *tg) { }
| ^~~~~~~~~~~~~~~~~~~
kernel/sched/rt.c:263:5: warning: no previous prototype for 'alloc_rt_sched_group' [-Wmissing-prototypes]
263 | int alloc_rt_sched_group(struct task_group *tg, struct task_group *parent)
| ^~~~~~~~~~~~~~~~~~~~
>> kernel/sched/rt.c:2496:13: warning: no previous prototype for 'init_sched_rt_fitness_mask' [-Wmissing-prototypes]
2496 | void __init init_sched_rt_fitness_mask(int cpu)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
--
In file included from kernel/sched/build_utility.c:87:
kernel/sched/cpupri.c: In function 'cpupri_find_fitness':
>> kernel/sched/cpupri.c:255:27: warning: array subscript 0 is outside array bounds of 'bool[0]' {aka '_Bool[]'} [-Warray-bounds]
255 | if (fallback_found[0]) {
| ~~~~~~~~~~~~~~^~~
kernel/sched/cpupri.c:148:14: note: while referencing 'fallback_found'
148 | bool fallback_found[NUM_FITNESS_FN];
| ^~~~~~~~~~~~~~
kernel/sched/cpupri.c:180:36: warning: array subscript 0 is outside array bounds of 'bool[0]' {aka '_Bool[]'} [-Warray-bounds]
180 | if (!fallback_found[0]) {
| ~~~~~~~~~~~~~~^~~
kernel/sched/cpupri.c:148:14: note: while referencing 'fallback_found'
148 | bool fallback_found[NUM_FITNESS_FN];
| ^~~~~~~~~~~~~~
kernel/sched/cpupri.c:182:47: warning: array subscript 0 is outside array bounds of 'bool[0]' {aka '_Bool[]'} [-Warray-bounds]
182 | fallback_found[0] = true;
| ~~~~~~~~~~~~~~^~~
kernel/sched/cpupri.c:148:14: note: while referencing 'fallback_found'
148 | bool fallback_found[NUM_FITNESS_FN];
| ^~~~~~~~~~~~~~


vim +/init_sched_rt_fitness_mask +2496 kernel/sched/rt.c

2495
> 2496 void __init init_sched_rt_fitness_mask(int cpu)
2497 {
2498 cpumask_var_t *fitness_mask_array;
2499 unsigned int i;
2500
2501 if (!NUM_FITNESS_FN)
2502 return;
2503
2504 fitness_mask_array = kcalloc_node(NUM_FITNESS_FN, sizeof(cpumask_var_t),
2505 GFP_KERNEL, cpu_to_node(cpu));
2506
2507 per_cpu(local_cpu_fitness_mask, cpu) = fitness_mask_array;
2508
2509 for (i = 0; i < NUM_FITNESS_FN; i++) {
2510 zalloc_cpumask_var_node(&fitness_mask_array[i], GFP_KERNEL,
2511 cpu_to_node(cpu));
2512 }
2513 }
2514

--
0-DAY CI Kernel Test Service
https://01.org/lkp

\
 
 \ /
  Last update: 2022-05-15 02:55    [W:0.082 / U:2.852 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site